Make GetXmlDocsPath public and inheritdoc cref= functionality#83
Closed
erichiller wants to merge 8 commits intoRicoSuter:masterfrom
Closed
Make GetXmlDocsPath public and inheritdoc cref= functionality#83erichiller wants to merge 8 commits intoRicoSuter:masterfrom
erichiller wants to merge 8 commits intoRicoSuter:masterfrom
Conversation
Owner
|
Thanks for the PR. Please clean up unused spaces and use the code style already used in the project (e.g. { on new lines) and remove the editorconfig (we use VS defaults). |
|
@erichiller @RicoSuter are there any updates with this PR? |
Owner
|
In order to merge this PR:
|
Merged
Owner
|
Thanks for the contribution! However, the functionality in this PR has since been independently implemented on master:
Since all the key changes are already covered, I'm going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.editorconfigreflecting existing formatting styles